feat(node): Bump to latest @fastify/otel#19452
Merged
andreiborza merged 2 commits intodevelopfrom Feb 23, 2026
Merged
Conversation
This PR unvendors `@fastify/otel` and bumps to the latest version. We can do this now because the newest `minimatch` expanded node support to node 18. Closes: #19450
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Member
Author
|
- Cast instrumentFastify return type to prevent @fastify/otel types from leaking into the public API (fixes TS 3.8 and TS 5.0 compatibility) - Remove `service.name` span assertions no longer emitted by @fastify/otel@0.16.0 - Bump @sentry/node size limit from 167KB to 171KB
andreiborza
force-pushed
the
ab/unvendor-fastify-otel
branch
from
257f3eb to
7d4d732
Compare
chargome
approved these changes
Feb 23, 2026
chargome
reviewed
Feb 23, 2026
| data: { | ||
| 'sentry.origin': 'auto.http.otel.fastify', | ||
| 'sentry.op': 'request_handler.fastify', | ||
| 'service.name': 'fastify', |
Member
Author
There was a problem hiding this comment.
Goes against Otel spec to set a service name in an instrumentation, it's the SDK's responsibility, see fastify/otel#70 for detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unvendors
@fastify/oteland bumps to the latest version. We can do this now because the newestminimatchexpanded node support to node 18.Closes: #19450