ci(triage-skill): Run on opened issues#19423
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+4
to
+5
| issues: | ||
| types: [opened] |
There was a problem hiding this comment.
Bug: The workflow may fail when triggered by an issues event because INPUT_ISSUE_NUMBER is set from github.event.inputs.issue_number, which is undefined in that context.
Severity: HIGH
Suggested Fix
Provide a fallback value for the expression to prevent an evaluation error. Change INPUT_ISSUE_NUMBER: ${{ github.event.inputs.issue_number }} to INPUT_ISSUE_NUMBER: ${{ github.event.issue.number || github.event.inputs.issue_number || '' }}. This ensures the expression always evaluates successfully.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/triage-issue.yml#L4-L5
Potential issue: The GitHub Actions workflow is triggered by both `issues` and
`workflow_dispatch` events. The `INPUT_ISSUE_NUMBER` environment variable is set
directly from `${{ github.event.inputs.issue_number }}`. This property is only defined
for `workflow_dispatch` triggers. When the workflow runs on an `issues` event,
attempting to access this undefined property is likely to cause an expression evaluation
error, failing the workflow step before the script execution begins. This happens
despite the script's conditional logic, which would otherwise handle the value
correctly.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
Author
There was a problem hiding this comment.
yes it does. it uses the EVENT_ISSUE_NUMBER if it's triggered through issues.
EVENT_ISSUE_NUMBER: ${{ github.event.issue.number }}
INPUT_ISSUE_NUMBER: ${{ github.event.inputs.issue_number }}
run: |
if [ "$EVENT_NAME" = "issues" ]; then
ISSUE_NUM="$EVENT_ISSUE_NUMBER"
else
ISSUE_NUM="$INPUT_ISSUE_NUMBER"
fi
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
chargome
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19424 (added automatically)