Skip to content

Comments

fix(core,browser): Delete SentryNonRecordingSpan from fetch/xhr map#19336

Merged
JPeer264 merged 1 commit intodevelopfrom
jp/span-leak
Feb 16, 2026
Merged

fix(core,browser): Delete SentryNonRecordingSpan from fetch/xhr map#19336
JPeer264 merged 1 commit intodevelopfrom
jp/span-leak

Conversation

@JPeer264
Copy link
Member

@JPeer264 JPeer264 commented Feb 16, 2026

This resolves a leak where SentryNonRecordingSpan are pilled up when tracingSampleRate is set to 0. Theoretically SentryNonRecordingSpan are still treated as spans and added to the spans list, but never removed

By moving shouldCreateSpanResult closer to the actual span logic, this is now resolved.

Closes #19337 (added automatically)

Copy link

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSYM!

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2026

Codecov Results 📊


Generated by Codecov Action

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,962 - 8,792 +2%
GET With Sentry 1,539 17% 1,673 -8%
GET With Sentry (error only) 5,883 66% 6,131 -4%
POST Baseline 1,154 - 1,193 -3%
POST With Sentry 559 48% 594 -6%
POST With Sentry (error only) 1,023 89% 1,046 -2%
MYSQL Baseline 3,086 - 3,254 -5%
MYSQL With Sentry 299 10% 462 -35%
MYSQL With Sentry (error only) 2,553 83% 2,628 -3%

View base workflow run

@JPeer264 JPeer264 merged commit 9b30bd7 into develop Feb 16, 2026
222 checks passed
@JPeer264 JPeer264 deleted the jp/span-leak branch February 16, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(core,browser): Delete SentryNonRecordingSpan from fetch/xhr map

3 participants