Skip to content

Comments

chore(node-core): Make @sentry/opentelemetry not a peer dep in node-core#19308

Merged
andreiborza merged 2 commits intodevelopfrom
ab/astro-node-core
Feb 12, 2026
Merged

chore(node-core): Make @sentry/opentelemetry not a peer dep in node-core#19308
andreiborza merged 2 commits intodevelopfrom
ab/astro-node-core

Conversation

@andreiborza
Copy link
Member

@andreiborza andreiborza commented Feb 12, 2026

Unblocking CI.

Closes #19309 (added automatically)

Astro 5.17.2 changed host header validation to fall back to "localhost"
(without port) when no `allowedDomains` is configured, breaking internal
fetch requests in SSR pages. This caused the nested SSR route E2E tests
to time out waiting for the API endpoint transaction.
@andreiborza andreiborza enabled auto-merge (squash) February 12, 2026 20:16
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

Codecov Results 📊


Generated by Codecov Action

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,343 - 9,454 -12%
GET With Sentry 1,539 18% 1,672 -8%
GET With Sentry (error only) 5,910 71% 6,107 -3%
POST Baseline 1,147 - 1,208 -5%
POST With Sentry 513 45% 595 -14%
POST With Sentry (error only) 1,006 88% 1,077 -7%
MYSQL Baseline 3,127 - 3,319 -6%
MYSQL With Sentry 488 16% 467 +4%
MYSQL With Sentry (error only) 2,593 83% 2,697 -4%

View base workflow run

@andreiborza andreiborza changed the title chore(node-core): Make @sentry/opentelemetry not a peer dep in node… chore(node-core): Make @sentry/opentelemetry not a peer dep in node-core Feb 12, 2026
@andreiborza andreiborza merged commit 9fdc259 into develop Feb 12, 2026
157 checks passed
@andreiborza andreiborza deleted the ab/astro-node-core branch February 12, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(node-core): Make @sentry/opentelemetry not a peer dep in node…

2 participants