ref(core): Use serializeAttributes for metric attribute serialization#18582
Merged
ref(core): Use serializeAttributes for metric attribute serialization#18582
serializeAttributes for metric attribute serialization#18582Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Lms24
force-pushed
the
lms/ref-core-metrics-logs-unify
branch
from
9d87fba to
0a298b5
Compare
Member
Author
|
Update: Fixed |
Lms24
force-pushed
the
lms/ref-core-metrics-logs-unify
branch
from
9019898 to
9105768
Compare
Lms24
commented
Jan 8, 2026
Comment on lines
+87
to
89
| if (!useFallback || (useFallback === 'skip-undefined' && value === undefined)) { | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
So this is a fun one: metrics and logs attribute setting logic already diverged prior to this PR: undefined values were
- stringified to
''in logs - ignored (not sent) in metrics
I therefore had to make the fallback behavior a tri-state flag. true ignores non-conforming values, 'skip-undefined also ignores undefined in addition, false completely ignores non-conforming values.
AbhiPrasad
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-work for #18160
Use the same attibute serialization logic we already use in logs.
Bundle size impact:
I think the largest positive long-term aspect of this refactor is that we'll re-use this logic more and more going forward (scope attributes on metrics, spansv2, and other telemetry items in the future), so I'd like to have it unified.