ci(v7): Bump to ubuntu-24.04 by mydea · Pull Request #17083 · getsentry/sentry-javascript

mydea · 2025-07-18T11:20:03Z

ubuntu-20.04 is no longer working, so CI is no longer working and nothing can be merged in v7 :O

Changes required to make this work:

Skip all playwright tests on CI :( We need to manually test changes locally instead. Playwright in this version simply does not like ubuntu-24.04
Skip mongoose/mongodb tests because they somehow also fail
Stop compiling node profiling binaries - we vendor them in instead
Size limit action fails because the comparison artifacts have expired 😅

github-actions · 2025-07-18T11:49:41Z

size-limit report 📦

Path	Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)	80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)	71.9 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)	76.15 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)	65.53 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped)	35.78 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)	35.67 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped)	31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)	31.73 KB (added)
@sentry/browser - Webpack (gzipped)	22.92 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)	79.18 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)	70.5 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)	36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped)	25.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)	221.94 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)	109.54 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)	76.26 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)	39.48 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)	72.4 KB (added)
@sentry/react - Webpack (gzipped)	22.95 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)	90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped)	54.28 KB (added)
@sentry-internal/feedback - Webpack (gzipped)	17.34 KB (added)

ubuntu-20.04 is no longer working Revert "try 22.04" This reverts commit 6f6cd22.

fix profiling stuff fix profiling node fix tarball cache

fix prisma ??

This reverts commit 0cfb644.

This reverts commit 4984514.

cursor

Bug: Playwright Tests Fail Due to Missing Dependencies

Playwright tests are failing on Ubuntu 24.04 runners in job_nextjs_integration_test, job_browser_playwright_tests, and job_browser_loader_tests. This is because the npx playwright install --with-deps flag and the npx playwright install-deps step were removed from these jobs. Although OS dependencies are installed in job_install_deps, each GitHub Actions job runs on a fresh runner, preventing these dependencies from being available to the separate Playwright test jobs.

.github/workflows/build.yml#L614-L620

sentry-javascript/.github/workflows/build.yml

Lines 614 to 620 in 5e1e26b

    
               key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}} 
        
           - name: Install Playwright browser if not cached 
        
             if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14 
        
             run: npx playwright install 
        
             env: 
        
               PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}} 
        
           - name: Run tests

.github/workflows/build.yml#L706-L710

sentry-javascript/.github/workflows/build.yml

Lines 706 to 710 in 5e1e26b

    
           - name: Install Playwright browser if not cached 
        
             if: steps.playwright-cache.outputs.cache-hit != 'true' 
        
             run: npx playwright install 
        
             env: 
        
               PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}

.github/workflows/build.yml#L759-L763

sentry-javascript/.github/workflows/build.yml

Lines 759 to 763 in 5e1e26b

    
           - name: Install Playwright browser if not cached 
        
             if: steps.playwright-cache.outputs.cache-hit != 'true' 
        
             run: npx playwright install 
        
             env: 
        
               PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}

Fix in Cursor • Fix in Web

Bug: Missing Directory Causes Build Script Failure

The build:copy-bindings script attempts to copy from compiled-bindings/ to lib/. However, the node-gyp build steps (and associated CI job) that previously created and populated compiled-bindings/ have been removed. This results in the compiled-bindings/ directory not existing, causing the cp command to fail and break the build process.

packages/profiling-node/package.json#L53-L54

sentry-javascript/packages/profiling-node/package.json

Lines 53 to 54 in 5e1e26b

    
           "build:types:watch": "tsc -p tsconfig.types.json --watch", 
        
           "build:copy-bindings": "cp -r compiled-bindings/ lib/",

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

cursor

Bug: Playwright Browser Installation Script Removed

The postinstall script, which automatically installed Playwright browsers via yarn install-browsers, was removed. This causes browser integration tests to fail due to missing browsers unless they are manually installed.

dev-packages/browser-integration-tests/package.json#L14-L16

sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 16 in 353f1ef

    
           "fix": "eslint . --format stylish --fix", 
        
           "type-check": "tsc", 
        
           "pretest": "yarn clean && yarn type-check",

Fix in Cursor • Fix in Web

cursor · 2025-07-24T11:53:09Z

.github/workflows/build.yml

    name: Nextjs (Node ${{ matrix.node }}) Tests
    needs: [job_get_metadata, job_build]
-    if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request'
+    if: false


Bug: Next.js Integration Tests Disabled

The job_nextjs_integration_test is completely disabled by setting its if condition to false. This likely accidental change prevents important Next.js integration tests from running, potentially masking functionality issues, especially after the upgrade to Ubuntu 24.04.

Locations (1)

.github/workflows/build.yml#L540-L541

Fix in Cursor • Fix in Web

.github/workflows/build.yml

cursor · 2025-07-24T12:10:28Z

packages/profiling-node/package.json

-    "test:bundle": "node test-binaries.esbuild.js",
-    "test": "cross-env SENTRY_PROFILER_BINARY_DIR=lib jest --config jest.config.js"
+    "test:watch": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --watch",
+    "test": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --config jest.config.js"


Bug: Node Profiling Build Fails Due to Missing Bindings

The packages/profiling-node build and test scripts now rely on a compiled-bindings directory that is never created or populated. The build:copy-bindings script attempts to copy from this non-existent directory, leading to build failures. Similarly, test scripts set SENTRY_PROFILER_BINARY_DIR to this missing directory, preventing tests from running. This change removed the previous node-gyp steps responsible for generating these bindings.

Locations (1)

packages/profiling-node/package.json#L53-L60

Fix in Cursor • Fix in Web

This reverts commit a4f08e9.

cursor

Bug: Missing Postinstall Script Causes Test Failures

The postinstall script, "yarn install-browsers", was removed from dev-packages/browser-integration-tests/package.json. This script automatically installed Playwright browsers. Its removal prevents automatic browser installation during dependency setup, leading to browser integration test failures for local developers.

dev-packages/browser-integration-tests/package.json#L14-L15

sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 15 in 3e6a498

    
           "fix": "eslint . --format stylish --fix", 
        
           "type-check": "tsc",

Fix in Cursor • Fix in Web

This PR unblocks backports to `v8` branch, similarly to what's done for v7 (#17083) Summary: - Skip `size-check` - Skip webkit / firefox playwright tests (so also flaky test detection) - Upgrade playwright versions to `1.52.0` - Skip a few browser tests that are flaky or failing on ubuntu-24.04 - Update nuxt e2e test configurations - Use node-profiler binding binaries - Skip nextjs canary tests - Skip mongodb, mongoose and amqplib tests

mydea requested review from Lms24 and andreiborza July 18, 2025 11:20

mydea self-assigned this Jul 18, 2025

andreiborza approved these changes Jul 18, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

mydea force-pushed the fn/v7-ubuntu-ci branch from e93336e to dc0a5ef Compare July 18, 2025 12:06

Lms24 approved these changes Jul 18, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

mydea force-pushed the fn/v7-ubuntu-ci branch from a9b40fd to 8e31cc6 Compare July 21, 2025 08:36

This comment was marked as outdated.

Sign in to view

mydea force-pushed the fn/v7-ubuntu-ci branch from 8e31cc6 to e961bc3 Compare July 21, 2025 09:02

This comment was marked as outdated.

Sign in to view

mydea added 7 commits July 21, 2025 11:46

ci(v7): Bump to ubuntu-24.04

574e589

ubuntu-20.04 is no longer working Revert "try 22.04" This reverts commit 6f6cd22.

skip serverless tests on Node < 14

547285e

bump playwright to ~1.52.0

0cfb644

feat(profiling-node): Vendor snapshots of compiled bindings

d95cf8c

fix profiling stuff fix profiling node fix tarball cache

bump prisma version

aa7458a

fix prisma ??

pin remix version

47410b1

Revert "bump playwright to ~1.52.0"

a43bd04

This reverts commit 0cfb644.

mydea force-pushed the fn/v7-ubuntu-ci branch from 025fd11 to a43bd04 Compare July 21, 2025 10:49

install playwright OS dependencies

c8c5850

This comment was marked as outdated.

Sign in to view

more packages....

4984514

This comment was marked as outdated.

Sign in to view

mydea added 3 commits July 21, 2025 13:54

Revert "more packages...."

37dc01c

This reverts commit 4984514.

manually install os deps???

d5a03c8

?? karma

d6f0a1d

This comment was marked as outdated.

Sign in to view

manually install deps

5e1e26b

cursor bot reviewed Jul 21, 2025

View reviewed changes

mydea added 4 commits July 24, 2025 13:44

skip playwright tests on CI

e053167

stop installing playwright OS deps

01e73a1

do not install playwright on postinstall

566136e

fix yarn locks in node-integration-tests

353f1ef

cursor bot reviewed Jul 24, 2025

View reviewed changes

prisma test fixes

f7b81d0

cursor bot reviewed Jul 24, 2025

View reviewed changes

mydea added 4 commits July 24, 2025 14:19

skip prisma test

79c3217

bump mongo and mongoose a bit...?

a4f08e9

Revert "bump mongo and mongoose a bit...?"

f1589ac

This reverts commit a4f08e9.

skip mongo tests

3e6a498

cursor bot reviewed Jul 24, 2025

View reviewed changes

mydea added 2 commits July 24, 2025 15:46

skip size limit

5be3ab6

fix linting

c524a4e

mydea merged commit bc8bbb6 into v7 Jul 24, 2025
80 of 82 checks passed

mydea deleted the fn/v7-ubuntu-ci branch July 24, 2025 15:03

mydea mentioned this pull request Jul 24, 2025

ci(v8): Bump to ubuntu-24.04 #17160

Closed

AdriVanHoudt mentioned this pull request Aug 22, 2025

@sentry/profiling-node@7.120.4 doesn't use pre build binaries #17442

Closed

3 tasks

mydea mentioned this pull request Sep 2, 2025

fix(v8/react): Add support for React Router sub-routes from handle (#17277) #17433

Closed

onurtemizkan mentioned this pull request Sep 11, 2025

ci(v8): Bump to ubuntu-24.04 #17507

Merged

	key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
	- name: Install Playwright browser if not cached
	if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
	run: npx playwright install
	env:
	PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
	- name: Run tests

	"build:types:watch": "tsc -p tsconfig.types.json --watch",
	"build:copy-bindings": "cp -r compiled-bindings/ lib/",

	"fix": "eslint . --format stylish --fix",
	"type-check": "tsc",
	"pretest": "yarn clean && yarn type-check",

Uh oh!

Comments

Conversation

mydea commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Playwright Tests Fail Due to Missing Dependencies

Bug: Missing Directory Causes Build Script Failure

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Playwright Browser Installation Script Removed

Uh oh!

cursor bot Jul 24, 2025

Choose a reason for hiding this comment

Bug: Next.js Integration Tests Disabled

Uh oh!

Uh oh!

cursor bot Jul 24, 2025

Choose a reason for hiding this comment

Bug: Node Profiling Build Fails Due to Missing Bindings

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Missing Postinstall Script Causes Test Failures

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mydea commented Jul 18, 2025 •

edited

Loading

github-actions bot commented Jul 18, 2025 •

edited

Loading