feat(node): Capture exceptions from worker_threads#15105
Merged
AbhiPrasad merged 14 commits intodevelopfrom Jan 21, 2025
Merged
feat(node): Capture exceptions from worker_threads#15105AbhiPrasad merged 14 commits intodevelopfrom
worker_threads#15105AbhiPrasad merged 14 commits intodevelopfrom
Conversation
worker_threadschildProcessIntegration Tests
…ry/sentry-javascript into timfish/feat/child-process-extra
childProcessIntegration Testsworker_threads
Contributor
size-limit report 📦
|
…ry/sentry-javascript into timfish/feat/child-process-extra
AbhiPrasad
approved these changes
Jan 21, 2025
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Do the events captured from worker_threads get the correct trace id attached to them?
I wonder if we should be propagating the trace context to the worker threads scope with this integration as well 🤔
Collaborator
Author
|
Currently this works even without Sentry running in the worker thread and because it uses |
Contributor
|
Let's open a draft PR for this in the docs, we can only merge it in when we release v9 though. I don't think we should backport this, we can make it a new feature for v9+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
childProcessIntegrationto captureworker_threadserrors (including their stack traces) rather than capturing a breadcrumb.This features is enabled by default and can be disabled by setting the
captureWorkerErrorsoption tofalse:When
captureWorkerErrors: false, a breadcrumb will be captured instead.This PR also adds more integration tests for the
childProcessIntegration.