Conversation
…injection Replace child_process.execSync() with child_process.execFileSync() to eliminate potential command injection vulnerabilities. While the original code used hardcoded arguments, using execFileSync with an array of arguments is a more secure approach that prevents shell interpretation. Changes: - Replace execSync with execFileSync for clang-format execution - Replace execSync with execFileSync for git status execution - Pass arguments as arrays instead of shell command strings Fixes: https://linear.app/getsentry/issue/VULN-1070 Fixes: https://linear.app/getsentry/issue/JS-1460
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧Release
Other
🤖 This preview updates automatically when you update the PR. |
timfish
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a potential command injection vulnerability by replacing
child_process.execSync()withchild_process.execFileSync()in the clang-format script.Changes
execSyncwithexecFileSyncfor clang-format executionexecSyncwithexecFileSyncfor git status executionSecurity Impact
While the original code used hardcoded arguments (making it a false positive in practice), using
execFileSyncwith an array of arguments is a more secure approach that:Testing
The clang-format script has been tested and continues to work correctly with the new implementation.
References