Skip to content

Improving example#1

Open
xiam wants to merge 4 commits into
masterfrom
hotfix/buildable-example
Open

Improving example#1
xiam wants to merge 4 commits into
masterfrom
hotfix/buildable-example

Conversation

@xiam
Copy link
Copy Markdown

@xiam xiam commented Dec 23, 2015

No description provided.

@xiam
Copy link
Copy Markdown
Author

xiam commented Jan 9, 2016

Would you like to give this PR a look @uaalto, @atavism?

@uaalto
Copy link
Copy Markdown
Contributor

uaalto commented Jan 12, 2016

make fails with Failed to notify ProjectEvaluationListener.afterEvaluate(), but primary configuration failure takes precedence. java.lang.RuntimeException: SDK location not found. Define location with sdk.dir in the local.properties file or with an ANDROID_HOME environment variable.
Perhaps add this to the README instructions (since they are very detailed, maybe this is also relevant).

Just exporting ANDROID_HOME with the SDK home directory does the trick. Usually Android developers will have this set, so maybe is not that important.

@uaalto
Copy link
Copy Markdown
Contributor

uaalto commented Jan 12, 2016

The README doesn't reflect the new name (formerly lantern-android-tester). Also, when I open the directory Android Studio doesn't show any signs of a project (no active buttons, no way of running the project). I'm using Android Studio 1.5, are you using a similar version?

@uaalto
Copy link
Copy Markdown
Contributor

uaalto commented Jan 12, 2016

Ah ok, it needs to index files before (??), which takes forever... now the run button is active and runs ok.

@uaalto
Copy link
Copy Markdown
Contributor

uaalto commented Jan 12, 2016

This PR is ready to merge, the README updates can be done here or in another PR. What do you prefer, @xiam ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants