Fix cli-plan test failing on Windows#252
Open
brunoleemann-code wants to merge 1 commit intogetagentseal:mainfrom
Open
Fix cli-plan test failing on Windows#252brunoleemann-code wants to merge 1 commit intogetagentseal:mainfrom
brunoleemann-code wants to merge 1 commit intogetagentseal:mainfrom
Conversation
os.homedir() on Windows uses USERPROFILE, not HOME. Set both env vars in the test so the temp dir is respected as the home directory on all platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.homedir()on Windows readsUSERPROFILE, notHOME. The test was only settingHOME, so the CLI wrote config to the real home directory instead of the temp dir, causing the assertion to fail.Fix: also set
USERPROFILE,HOMEPATH, andHOMEDRIVEin the test's spawned process environment, matching what Windows actually uses.Test plan
npx vitest run tests/cli-plan.test.tson Windows — should pass (was failing before this fix)