Fix amount input ticker visibility and locale-aware symbol position#384
Draft
DRadmir wants to merge 1 commit into
Draft
Fix amount input ticker visibility and locale-aware symbol position#384DRadmir wants to merge 1 commit into
DRadmir wants to merge 1 commit into
Conversation
Closes #287, closes #333. - Rewrite CurrencyTextField as UIViewRepresentable with adjustsFontSizeToFitWidth so the currency symbol stays glued to the digits and both shrink together when the amount is long (#287). - Add CurrencySymbolPosition to CurrencyFormatter and use it in fiat configs so the symbol position follows the locale instead of being hardcoded to leading (#333). - Slim CurrencyInputConfigurable: composing/stripping and live formatting live in CurrencyTextField; sanitizer is now a protocol method with an identity default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CurrencyTextFieldasUIViewRepresentablewithadjustsFontSizeToFitWidthso the currency symbol stays glued to the digits and both shrink together when the amount is long.NumberFormatter.positivePrefixto derive the currency symbol position per locale instead of hardcoding.leadingfor fiat —$50foren_US,50 €forfr_FR,50 ₽forru_RU.CurrencyInputConfigurable: composing/stripping and live formatting moved intoCurrencyTextField; sanitizer is now a protocol method with an identity default.Closes #287, closes #333.
iOS
Simulator.Screen.Recording.-.iPhone.Air.-.2026-05-25.at.22.56.28.mov