Skip to content

Minor fixes to terraform skill#90

Merged
haroonc merged 3 commits intomainfrom
terraform-fix
Mar 11, 2026
Merged

Minor fixes to terraform skill#90
haroonc merged 3 commits intomainfrom
terraform-fix

Conversation

@yeshwanth1993
Copy link
Contributor

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the implementation phase within the CI/CD design process by introducing more flexible execution paths, including a dedicated Terraform workflow. It also refines existing skill documentation to improve clarity, enforce best practices, and provide more robust guidance for cloud infrastructure provisioning and management.

Highlights

  • Enhanced Implementation Strategy: The gcp-cicd-design skill now offers users a choice between Terraform-based and Direct Implementation methods for executing approved YAML plans, providing detailed protocols for each approach.
  • Terraform Skill Refinements: The terraform-gcp-skill documentation has been updated with a new version, clearer guidance on GCS backend usage, a stronger warning against google_project_iam_policy, and an updated recommended directory structure.
  • Documentation Clarity: Minor documentation improvements were made across other skills, including adding a version to cloud-deploy-pipelines and emphasizing multi-stage Docker builds.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • skills/cloud-deploy-pipelines/SKILL.md
    • Added version 0.1.0 to the skill metadata.
  • skills/gcp-cicd-design/SKILL.md
    • Revised the 'Plan Implementation' stage to introduce a choice between Terraform and Direct Implementation methods.
    • Detailed the execution steps for both Terraform (activating terraform-gcp-skill, HCL translation, execution protocol) and Direct Implementation (sequential processing, skill/tool leveraging, gcloud fallback).
    • Removed the 'Execution Mandate' section, which previously instructed immediate execution of the first workflow step.
  • skills/gcp-cicd-design/references/how_to_write_dockerfile.md
    • Added a strong recommendation to always use multi-stage Docker builds when possible.
  • skills/gcp-cicd-terraform/SKILL.md
    • Updated the terraform-gcp-skill version from 1.0.0 to 0.1.0.
    • Added a note to include local state directories in .gitignore when using a GCS backend.
    • Strengthened the warning against using google_project_iam_policy from 'Avoid' to 'Never use'.
    • Modified the recommended directory structure to include a terraform/ subdirectory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces version metadata to the cloud-deploy-pipelines skill and updates it for the terraform-gcp-skill. It significantly refactors the gcp-cicd-design skill's implementation stage to offer users a choice between Terraform-based and direct implementation, detailing the steps for each, and removes a previous 'Execution Mandate'. Additionally, it emphasizes the use of multi-stage Docker builds, adds a .gitignore recommendation for local Terraform state, strengthens the warning against using google_project_iam_policy, and updates the recommended Terraform project structure to include a terraform/ subdirectory.

haroonc
haroonc previously approved these changes Mar 11, 2026
@haroonc haroonc merged commit b03633b into main Mar 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants