Skip to content

feat: add support for skills#109

Open
twishabansal wants to merge 14 commits intomainfrom
feat-skills
Open

feat: add support for skills#109
twishabansal wants to merge 14 commits intomainfrom
feat-skills

Conversation

@twishabansal
Copy link
Contributor

@twishabansal twishabansal commented Feb 27, 2026

Does not yet contain support for multiple sub-toolsets for cloudsql postgres

@github-actions github-actions bot requested a review from Myst9 February 27, 2026 07:40
@twishabansal twishabansal changed the title Feat skills feat: add support for skills Feb 27, 2026
@twishabansal twishabansal removed the request for review from Myst9 February 27, 2026 07:41
@twishabansal twishabansal changed the base branch from main to license-fix March 2, 2026 07:53
@twishabansal twishabansal marked this pull request as ready for review March 2, 2026 08:02
@twishabansal twishabansal requested review from a team as code owners March 2, 2026 08:02
Base automatically changed from license-fix to main March 2, 2026 08:02
@twishabansal twishabansal added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 3, 2026
}
},
"contextFileName": "CLOUD-SQL-POSTGRESQL.md",
"settings": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested with the settings in the .env and having the extension load in the env vars? Does this allow the agents to use these variables without additional input from the user?

Copy link
Contributor Author

@twishabansal twishabansal Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haoyu has edited his implementation to update the scripts to get the env vars from the global extension path. It is automatically set when the user runs gemini extensions install.

@@ -0,0 +1,704 @@
---
name: cloudsql-postgres
description: skill for running tool operations in CloudSql postgres
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the first iteration, we will have to manually add the descriptions since Grouping (with the descriptions) most likely wont be complete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean grouping will be complete but without the descriptions? For now, I will add the descriptions manually.

@helloeve
Copy link

helloeve commented Mar 4, 2026

Thank you Twisha for authoring this PR! After looking at the generated config, I realized there should be some improvements done to the skill generation logic we previously introduced.

  • As Averi pointed out, the env variable placeholder for defining the sources are not propagated as the current generation logic will rely on the parsed version of the environment variable rather than leaving it as a placeholder.
  • The generated skill.md is too large and I think we may want to move the tool-specific parameter definition into its own file under references/ to take advantages from skill's dynamic loading capability.

add presubmit workflow for skills

fix workflow

Update skills-validate.yml

fix workflows

ignore skills dir for license headers

update docs

fix header check

fix copyright year

test failure for validation workflow

revert skill testing failure

revert license file changes

add year pattern regex

test header check years

Update header-check.yml

Update settings

fix env var propagation

address comment
@twishabansal twishabansal requested review from averikitsch and helloeve and removed request for prernakakkar-google March 10, 2026 09:12
@twishabansal twishabansal removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants