Skip to content

chore: remove build files#15

Merged
gbprod merged 1 commit intogbprod:mainfrom
thatlittleboy:remove-build-files
Jan 2, 2023
Merged

chore: remove build files#15
gbprod merged 1 commit intogbprod:mainfrom
thatlittleboy:remove-build-files

Conversation

@thatlittleboy
Copy link
Copy Markdown
Contributor

@thatlittleboy thatlittleboy commented Jan 2, 2023

I noticed in other tree-sitter-xxx repos that the build/ directory is not present, so I'm assuming it's not useful when serving the package.
And this directory generates a lot of noise / potential for merge conflicts everytime we run npm run test if we keep it in the repo.

I propose we delete it. Feel free to close this PR if there's a specific reason why build/ is kept in that I'm missing :) - (in which case you'll want to remove it from the .gitignore?)

@gbprod
Copy link
Copy Markdown
Owner

gbprod commented Jan 2, 2023

You're right!
Thanks!

@gbprod gbprod merged commit d4c5031 into gbprod:main Jan 2, 2023
@thatlittleboy thatlittleboy deleted the remove-build-files branch January 2, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants