Skip to content

docs: add supported locale list to readme#13

Merged
gbprod merged 5 commits intogbprod:mainfrom
thatlittleboy:locale-info
Jan 2, 2023
Merged

docs: add supported locale list to readme#13
gbprod merged 5 commits intogbprod:mainfrom
thatlittleboy:locale-info

Conversation

@thatlittleboy
Copy link
Copy Markdown
Contributor

Fixes #9


Logs:

  • I just ran Google translate on the various text in grammar.js, please let me know if the list of languages I've compiled is inaccurate.

@gbprod
Copy link
Copy Markdown
Owner

gbprod commented Jan 2, 2023

Thanks for that!

Can you check if it matchs with git supported languages (https://github.com/git/git/tree/master/po) ans order languages alphabetically ?

@thatlittleboy
Copy link
Copy Markdown
Contributor Author

Yep will do :) Will push the updates up soon

@thatlittleboy
Copy link
Copy Markdown
Contributor Author

thatlittleboy commented Jan 2, 2023

I took reference from the "Please enter the commit message ..." line, and compared it against git's supported locales (the link u shared).

Currently, I think we're missing:

  • bg (Bulgarian)
  • is (Icelandic)

It is possible that the other languages are not completely supported in our grammar.js as well, since I only based it on this one line. But this should be good enough for now.

I also took the liberty to sort the translations inside grammar.js to this particular README order (i.e., alphabetical, except for English at the top) for this one line. I think it makes it easier to keep track of whether a particular line's translation is supported or not, but if you want me to revert this change, I can do so.

@gbprod
Copy link
Copy Markdown
Owner

gbprod commented Jan 2, 2023

Icelandic is empty and it seems that I've missed some Bulgarian translations 😅 , I create an issue

@gbprod
Copy link
Copy Markdown
Owner

gbprod commented Jan 2, 2023

Can you add a link to https://github.com/git/git/tree/master/po in the README ?

Thanks

@thatlittleboy
Copy link
Copy Markdown
Contributor Author

Done!

@gbprod
Copy link
Copy Markdown
Owner

gbprod commented Jan 2, 2023

Thanks!

@gbprod gbprod merged commit 5c88715 into gbprod:main Jan 2, 2023
@thatlittleboy thatlittleboy deleted the locale-info branch January 2, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List of languages supported by the parser

2 participants