Skip to content

added option to open devices on darwin in non-exclusive mode#132

Merged
gary-rowe merged 1 commit intogary-rowe:developfrom
DaPutzy:issue-131
Dec 5, 2022
Merged

added option to open devices on darwin in non-exclusive mode#132
gary-rowe merged 1 commit intogary-rowe:developfrom
DaPutzy:issue-131

Conversation

@DaPutzy
Copy link
Copy Markdown
Contributor

@DaPutzy DaPutzy commented Nov 20, 2022 •
edited
Loading

Closes #131

Requires libhidapi 0.12.0.

Tested locally with libhidapi.0.12.0.dylib and jna 5.8.0 on M1 Max Macbook Pro.

tresf
tresf reviewed Nov 20, 2022
View reviewed changes
Comment thread src/main/java/org/hid4java/jna/DarwinHidApiLibrary.java
@tresf
Copy link
Copy Markdown
Contributor

tresf commented Nov 20, 2022

Thanks for creating a separate PR! I think it will make it trivial for Gary to merge (e.g. vs. placing it on top of the arm64 PR).

I've reviewed the PR and it looks great. I just made a couple in-line comments.

tresf
tresf reviewed Nov 20, 2022
View reviewed changes
Comment thread src/main/java/org/hid4java/jna/DarwinHidApiLibrary.java
@gary-rowe gary-rowe merged commit 5e0b9bd into gary-rowe:develop Dec 5, 2022
@gary-rowe
Copy link
Copy Markdown
Owner

gary-rowe commented Dec 5, 2022

Thank you @DaPutzy and @tresf for implementing and reviewing it. I think it'll be a great addition to hid4java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gary-rowe gary-rowe gary-rowe approved these changes

+1 more reviewer

@tresf tresf tresf left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option to open device in non-exclusive mode

3 participants

@DaPutzy @tresf @gary-rowe