Improvements to MacOS builds#116
Conversation
Closes gary-rowe#114 Make colors easier to read in the shell script
Wait 30s for testing as logs indicate
Also adds some sanitization to the build-hidapi.sh
|
Hi! I opened this issue a couple days ago and created a little patch to add the "non-exclusive device open mode" for mac os. I feel like this would be a great addition to this PR! It does require |
Thanks! Can you please open a separate PR for this patch?
Since it modifies the default behavior I think it should be separate for better tracking, but it definitely improves the quality of life for MacOS users. I haven't read the
AFAIR, the build system always uses the latest version from upstream. |
|
I implemented a toggle and the default behaviour is the same as before :) I build this on top of your PR but i just noticed you only changed the build anyway so there should be no issue creating a separate PR. |
|
Created a new PR as discussed 👍 |
Note before merging: This PR contains commits from #115, but they can be refactored out once that branch is merged into
develop.Relevant commits:
.dylibfiles for separate architectures on MacOS)make clean(Closes build-hidapi.sh: Remove calls to "make clean" #122)SDKROOT,MACOSX_DEPLOYMENT_TARGET(Closes Building for MacOS should encourage setting an SDK version #120)Related #108