shouldDeleteModernInstanceMethod shouldn’t call get()

[fionawhim]

The shouldDeleteModernInstanceMethod assumes that if prototypeDescription.get exists, that get() will return something. When using MobX’s @action, the decorator creates a get that returns undefined, which causes an exception when accessing length on line 31.

I’m not sure if a get() result of undefined should be treated like a length of 0 or get not existing in the first place. (Or if this issue really belongs to MobX.)

[fionawhim]

Digging deeper into this, I think that it’s actually a bug that get() is called. Does the code intend to just call get.length in the code below, since get(), as the property’s getter, would actually return the property value?

  if (prototypeDescriptor.get().length !== component[name].length) {
    // The length doesn't match, bail out
    return false;
  }

[jeffijoe]

Running into this as well, I also use MobX.