Skip to content

gracefully handle exceptions during MRD and AAOW close#763

Merged
ankitaluthra1 merged 1 commit into
fsspec:mainfrom
ankitaluthra1:zonalfile-close
Mar 4, 2026
Merged

gracefully handle exceptions during MRD and AAOW close#763
ankitaluthra1 merged 1 commit into
fsspec:mainfrom
ankitaluthra1:zonalfile-close

Conversation

@suni72

@suni72 suni72 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Graceful teardown: Added close_mrd and close_aaow utility wrappers to zb_hns_utils.py. These functions gracefully catch and log teardown exceptions as warnings instead of crashing the application.
  • Implementation: Replaced direct mrd.close() and aaow.close() calls in ZonalFile and ExtendedGcsFileSystem with the new safe-teardown wrappers.
  • Testing: Added unit tests for the closure utilities.

@suni72 suni72 marked this pull request as ready for review February 23, 2026 14:52
@codecov

codecov Bot commented Feb 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.14%. Comparing base (de0ad00) to head (b31452c).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
gcsfs/extended_gcsfs.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   75.88%   76.14%   +0.26%     
==========================================
  Files          19       19              
  Lines        2924     2935      +11     
==========================================
+ Hits         2219     2235      +16     
+ Misses        705      700       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread gcsfs/zb_hns_utils.py
@ankitaluthra1

Copy link
Copy Markdown
Collaborator

/gcbrun

@ankitaluthra1 ankitaluthra1 merged commit e0ef1b3 into fsspec:main Mar 4, 2026
9 checks passed
@suni72 suni72 deleted the zonalfile-close branch March 11, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants