fix(publish): resilient publishing and reordered flow#315
Merged
Conversation
Nix and Docker build failures were preventing cargo publish from running due to the sequential short-circuit flow.
Build from source when cache substituters have network issues.
Auto-create a GitHub release on 404 instead of failing, only triggered when the release genuinely doesn't exist.
fslabs-bot
Bot
added
the
size/XXL
loispostula
force-pushed
the
lp/fix-publishing
branch
from
89cc6c5 to
469ae39
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bonsairobo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fslabs-bot
Bot
added
the
approved
loispostula
force-pushed
the
lp/fix-publishing
branch
from
469ae39 to
0518baa
Compare
fslabs-bot
Bot
added
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--fallbacktonix buildso it builds from source when cache substituters have network issuesContext
The
publish-allProw job was failing due to transient network errors downloading from the Nix cache (SSL_ERROR_SYSCALL, curl failures). Because the publish flow short-circuits, this also prevented cargo publish from running. Additionally,report_publish_to_githubwas failing with "Could not find a release with tag" sinceHANDLE_TAGS=falsemeans no release is pre-created.