Skip to content

sort unused patches in fix-lock-files#311

Merged
fslabs-bot[bot] merged 2 commits into
mainfrom
ad/sort-unused-patches
Mar 17, 2026
Merged

sort unused patches in fix-lock-files#311
fslabs-bot[bot] merged 2 commits into
mainfrom
ad/sort-unused-patches

Conversation

@atlv24

@atlv24 atlv24 commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

apparently cargo has a bug where unused patches are not deterministically ordered. this causes ci to fail on the lock diff when the order changes. so to fix this we sort the unused patch entries by crate name and version.

@fslabs-bot fslabs-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2026
@fslabs-bot

fslabs-bot Bot commented Mar 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sixfold-origami

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fslabs-bot fslabs-bot Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026
@fslabs-bot fslabs-bot Bot merged commit 30891cf into main Mar 17, 2026
2 checks passed
@fslabs-bot fslabs-bot Bot deleted the ad/sort-unused-patches branch March 17, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants