fix crate graph traversal#308
Merged
Merged
Conversation
fslabs-bot
Bot
added
the
size/M
loispostula
requested changes
Mar 11, 2026
loispostula
left a comment
loispostula
left a comment
Member
There was a problem hiding this comment.
Can you add a test to crate_graph to cover this, and especially the case you are trying to solve?
It's unclear to me why this is needed
loispostula
approved these changes
Mar 13, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: loispostula The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fslabs-bot
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we need this so that fdk_apps gets found in the mono-workspace