feat: adding offset props for dropdown#324
Merged
Merged
Conversation
cmp831
previously approved these changes
Jun 16, 2026
cmp831
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added support to pass offset.skidding and offset.distance for offset react-popper prop.
This will allow us to move a popper dropdown as a whole instead of using css, why ? using css won't resolve the root problem, it we're moving using css (relative positions with left, right or adding paddings or margins) because it will only display the content component but not the layer itself.
using css will keep the layer where it's created and it will overlap content behind and as a result it will avoid pointer events behind elements.
Screenshot
I added some storybook args for the nested dropdown component, so now we can use storybook for testing this new config props (for submenu only)