fix: sort programmatic routes by specificity to prevent shadowing#3865
Open
SisyphusZheng wants to merge 3 commits into
Open
fix: sort programmatic routes by specificity to prevent shadowing#3865SisyphusZheng wants to merge 3 commits into
SisyphusZheng wants to merge 3 commits into
Conversation
A previous commit accidentally changed \import prefresh from\ to \import { prefresh } from\ and modified regex escaping in the exclude array. Revert both files to match main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes registered via
app.route()/app.get()are matched in registration order (first-wins). File-system routes go throughsortRoutePaths()which orders by specificity, but programmatic routes bypass this entirely. This means registering a catch-all before a specific route silently shadows it:This PR sorts
#dynamicArrwhenever a new dynamic route is added, using the same specificity scoring assortRoutePaths: static segments > dynamic[id]> catch-all[...rest].Closes #3861