Skip to content

Add SOAP encrypt and decrypt methods#11057

Open
nielsm5 wants to merge 11 commits into
masterfrom
task/implement-soap-encryption
Open

Add SOAP encrypt and decrypt methods#11057
nielsm5 wants to merge 11 commits into
masterfrom
task/implement-soap-encryption

Conversation

@nielsm5

@nielsm5 nielsm5 commented Jun 19, 2026

Copy link
Copy Markdown
Member

Changes

Add encrypt and decrypt methods for soap messages in the SoapWrapper.
The code is still unused, as in it cannot be triggered from an adapter/pipe/etc.

Pull Request Checklist

Title

  • Title expresses the business value (who benefits + what outcome)

Issues

  • Relevant issue(s) linked
  • Confirmed with the issue creator(s) that the solution is satisfactory

Backports

  • Backport PRs created (if needed) and linked

Documentation

  • FF! Reference updated (user-facing behaviour/config)
  • Javadoc updated/generated (developer-facing APIs)
  • FF! Docs updated (if applicable)

Tests

  • Unit tests added/updated
  • E2E/Integration tests added/updated (if applicable)

Breaking changes

  • Breaking change recorded in markdown file
  • Migration notes included (if needed)

@nielsm5 nielsm5 linked an issue Jun 19, 2026 that may be closed by this pull request
Comment thread core/src/main/java/org/frankframework/soap/KeyStoreCrypto.java Fixed
Comment thread core/src/main/java/org/frankframework/soap/KeyStoreCrypto.java Fixed
Comment thread core/src/main/java/org/frankframework/soap/KeyStoreCrypto.java Fixed
@nielsm5 nielsm5 requested review from evandongen and tnleeuw June 22, 2026 12:17

@tnleeuw tnleeuw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we already add some configuration-options to the SoapWrapper to encrype/decrypt the SOAP messages?

Comment thread core/src/main/java/org/frankframework/soap/SoapWrapper.java Outdated
Comment thread core/src/main/resources/AppConstants.properties
Comment thread core/src/main/java/org/frankframework/soap/KeyStoreCrypto.java
Comment thread core/src/main/java/org/frankframework/pipes/SignaturePipe.java
Comment thread core/src/test/java/org/frankframework/pipes/SignaturePipeTest.java Outdated
Comment thread core/src/test/java/org/frankframework/pipes/SignaturePipeTest.java Outdated
Comment thread core/src/main/java/org/frankframework/soap/SoapWrapper.java Outdated
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
26.9% Coverage on New Code (required ≥ 65%)
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Soap decryption pipe

4 participants