Skip to content

Add validation in Receiver (Take 2)#10923

Open
tnleeuw wants to merge 48 commits into
masterfrom
feature/6989_ValidatorInReceiver_ValidationByPipelineProcessor
Open

Add validation in Receiver (Take 2)#10923
tnleeuw wants to merge 48 commits into
masterfrom
feature/6989_ValidatorInReceiver_ValidationByPipelineProcessor

Conversation

@tnleeuw

@tnleeuw tnleeuw commented May 29, 2026

Copy link
Copy Markdown
Contributor

Changes

Add validation/wrapping directly on receivers, as an option.

Closes #6989.

This PR supercedes #10913

The new PR touches more files and changes the signature of the method Pipeline#process() to add the Receiver that invoked the pipeline.
This required a surprising number of fixes in tests.

However, the advantage of this is consistency with how validators/wrappers work when defined on pipelines and senders, and better error handling / construction of better error messages.

Pull Request Checklist

Title

  • Title expresses the business value (who benefits + what outcome)

Issues

  • Relevant issue(s) linked
  • Confirmed with the issue creator(s) that the solution is satisfactory

Backports

  • Backport PRs created (if needed) and linked

Documentation

  • FF! Reference updated (user-facing behaviour/config)
  • Javadoc updated/generated (developer-facing APIs)
  • FF! Docs updated (if applicable)

Tests

  • Unit tests added/updated
  • E2E/Integration tests added/updated (if applicable)

Breaking changes

  • Breaking change recorded in markdown file
  • Migration notes included (if needed)

tnleeuw and others added 26 commits May 19, 2026 18:04
…idator.java

Co-authored-by: Erik <dongenevan@gmail.com>
…unctionality much closer to validation specified on the pipeline.

Gives much better error handling than the first approach.
@tnleeuw tnleeuw requested review from evandongen and nielsm5 May 29, 2026 15:31
@tnleeuw tnleeuw self-assigned this May 29, 2026

@evandongen evandongen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wat een klus zeg. Mooi werk. Paar kleine dingetjes, verder akkoord!

Comment thread core/src/main/java/org/frankframework/core/PipeLineResult.java Outdated

@evandongen evandongen Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit was 'm waarschijnlijk? (voor de ladybug issues met aop)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dat, en daarvoor moest ik ook ongebruikte parameters toevoegen aan de method zelf...

tnleeuw and others added 6 commits June 5, 2026 17:21
…nByPipelineProcessor

# Conflicts:
#	core/src/main/java/org/frankframework/processors/CorePipeLineProcessor.java
#	core/src/main/resources/xml/xsd/FrankConfig-compatibility.xsd
#	core/src/main/resources/xml/xsd/FrankConfig.xsd
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possibility to specify wrappers and validators in the receiver

2 participants