Enhanced node components with improved shadow effects for better visual depth#537
Open
stijnpotters1 wants to merge 3 commits into
Open
Enhanced node components with improved shadow effects for better visual depth#537stijnpotters1 wants to merge 3 commits into
stijnpotters1 wants to merge 3 commits into
Conversation
Member
|
I think the shadow should go down. And the nested element has a weird inset shadow. |
Contributor
Author
I have improved it |
Member
Shadown only has offset down |
Contributor
Author
|
Like this? |
|
Member
|
When looking at the code, you did a pretty manual job for something that is built into Tailwind CSS. https://tailwindcss.com/docs/box-shadow Just use shadow-md and inset-shadow-md. I noticed that the configuration page also had some shadows and inset shadows. Could you make the shadows consistent over these two places? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
According to the #507 design
Global view:
