W-19408803: Add MainApplication.kt for hybrid Android apps#2930
Open
wmathurin wants to merge 4 commits into
Open
W-19408803: Add MainApplication.kt for hybrid Android apps#2930wmathurin wants to merge 4 commits into
wmathurin wants to merge 4 commits into
Conversation
…in, not Android repo
…mple app manifests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
HybridApp.javawithMainApplication.ktinlibs/SalesforceHybrid/src/com/salesforce/androidsdk/phonegap/app/.MainApplication.ktis the Kotlin replacement forHybridApp— it callsSalesforceHybridSDKManager.initHybrid()and includes commented-out hooks for IDP login and push notifications (matching the pattern in native Android templates). It has a real, valid package so it compiles cleanly as part of the library.update.shin CordovaPlugin explicitly copiesMainApplication.kttosrc/android/sopostinstall-android.jscan inject it into generated hybrid apps at a stable path — regardless of whether the app uses the dev composite build or Maven Central (GA).Also updates the two hybrid sample app manifests (
AccountEditor,MobileSyncExplorerHybrid) to referenceMainApplicationinstead ofHybridApp.GUS
W-19408803
Test plan
./gradlew :libs:SalesforceHybrid:compileDebugKotlinpassesMainApplication.ktat correct path with correct package and import