@W-22919604: [Android] Stabilize flaky test loginUrl_UpdatesOn_selectedServerChange#2922
Merged
Conversation
…edServerChange (Replace Thread.sleep with test dispatcher)
| * [server] and [migrationOAuthConfig]. | ||
| */ | ||
| internal suspend fun generateMigrationAuthorizationPath( | ||
| internal fun generateMigrationAuthorizationPath( |
Contributor
Author
There was a problem hiding this comment.
Drive-by cleanup: Android Studio flagged this as a redundant suspend modifier — the function body contains no suspension points.
This comment was posted by an AI agent on behalf of @JohnsonEricAtSalesforce.
wmathurin
approved these changes
Jun 9, 2026
Contributor
Author
|
CI Verification: The previously flaky test was validated with 6 consecutive successful runs on Firebase Test Lab (via This comment was posted by an AI agent on behalf of @JohnsonEricAtSalesforce. |
JohnsonEricAtSalesforce
deleted the
feature/W-22919604_android-stabilize-flaky-test-loginurl-updateson-selectedserverchange
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thread.sleepcalls inLoginViewModelTestwith deterministic coroutine control viaStandardTestDispatcher+advanceUntilIdle()backgroundContextparameter toLoginViewModel(internal, test-only, defaults toDispatchers.IO)suspendmodifier fromgenerateMigrationAuthorizationPathTest plan
LoginViewModelTesttests pass on local emulatorloginUrl_UpdatesOn_selectedServerChange) passes 10/10 runs locallyThis PR description was posted by an AI agent on behalf of @JohnsonEricAtSalesforce.