This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Make rendering template in agent client temporary#395
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 63.00% 64.22% +1.21%
==========================================
Files 154 156 +2
Lines 13084 10661 -2423
==========================================
- Hits 8244 6847 -1397
+ Misses 4222 3192 -1030
- Partials 618 622 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Aug 31, 2023
8 tasks
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
edwinyyyu
force-pushed
the
agent-render-fix
branch
from
19aa9e3 to
bf31a53
Compare
pingsutw
approved these changes
Sep 13, 2023
hamersaw
approved these changes
Sep 14, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 28, 2023
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
A render of the task template in the agent client can persist across multiple nodes. Solution stores the unrendered template in a separate variable and uses it to recover the unrendered template.
Type