This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Add Raw AWS Batch Task#228
Merged
Merged
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 62.30% 62.47% +0.16%
==========================================
Files 141 142 +1
Lines 8807 8868 +61
==========================================
+ Hits 5487 5540 +53
- Misses 2821 2822 +1
- Partials 499 506 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Kevin Su <pingsutw@apache.org>
kumare3
reviewed
Jan 19, 2022
Contributor
|
mostly looks good to me, but, looks a little more complicated because of the array case |
Signed-off-by: Kevin Su <pingsutw@apache.org>
hamersaw
reviewed
Jan 19, 2022
hamersaw
left a comment
Member
There was a problem hiding this comment.
Few questions regarding implementation and a couple nits. I think it looks great!
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
kumare3
reviewed
Jan 21, 2022
kumare3
reviewed
Jan 21, 2022
Signed-off-by: Kevin Su <pingsutw@apache.org>
EngHabu
reviewed
Jan 21, 2022
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
EngHabu
reviewed
Jan 25, 2022
Signed-off-by: Kevin Su <pingsutw@apache.org>
EngHabu
reviewed
Jan 28, 2022
EngHabu
approved these changes
Feb 2, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Add Raw AWS Batch Task Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix test Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix lint Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix lint Signed-off-by: Kevin Su <pingsutw@apache.org> * Add tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix lint Signed-off-by: Kevin Su <pingsutw@apache.org> * Remove log Signed-off-by: Kevin Su <pingsutw@apache.org> * Updated tests and added comment Signed-off-by: Kevin Su <pingsutw@apache.org> * address comment Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Convert pb to string Signed-off-by: Kevin Su <pingsutw@apache.org> * Use job definition as cache key Signed-off-by: Kevin Su <pingsutw@apache.org> * Fixed tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fixed tests Signed-off-by: Kevin Su <pingsutw@apache.org> * One more test Signed-off-by: Kevin Su <pingsutw@apache.org> * Hash job definition Signed-off-by: Kevin Su <pingsutw@apache.org> * address comments Signed-off-by: Kevin Su <pingsutw@apache.org> * Updated dependency Signed-off-by: Kevin Su <pingsutw@apache.org> * Fixed test Signed-off-by: Kevin Su <pingsutw@apache.org> * lint fixed Signed-off-by: Kevin Su <pingsutw@apache.org> * Reorder Signed-off-by: Kevin Su <pingsutw@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Su pingsutw@apache.org
TL;DR
Run regular tasks on AWS batch service
check example in flyteorg/flytekit#782
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#1792
flyteorg/flytekit#782
Follow-up issue
NA