Skip to content

Revert "Fixed format alias in Flytekit docs"#864

Closed
SmritiSatyanV wants to merge 1 commit into
masterfrom
revert-844-Flyte-format-alias
Closed

Revert "Fixed format alias in Flytekit docs"#864
SmritiSatyanV wants to merge 1 commit into
masterfrom
revert-844-Flyte-format-alias

Conversation

@SmritiSatyanV

Copy link
Copy Markdown
Contributor

Reverts #844

@codecov

codecov Bot commented Feb 23, 2022

Copy link
Copy Markdown

Codecov Report

Merging #864 (ac64434) into master (0d034c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #864   +/-   ##
=======================================
  Coverage   87.30%   87.30%           
=======================================
  Files         247      247           
  Lines       22184    22194   +10     
  Branches     2473     2473           
=======================================
+ Hits        19367    19377   +10     
  Misses       2389     2389           
  Partials      428      428           
Impacted Files Coverage Δ
flytekit/types/directory/__init__.py 100.00% <ø> (ø)
flytekit/types/file/file.py 90.78% <ø> (ø)
flytekit/types/schema/types.py 76.44% <ø> (ø)
flytekit/types/file/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d034c1...ac64434. Read the comment docs.

@cosmicBboy

Copy link
Copy Markdown
Contributor

let's first understand what's going on before reverting anything

@cosmicBboy

Copy link
Copy Markdown
Contributor

closing this PR, as it isn't needed. Docs breakage was fixed by #862

@cosmicBboy cosmicBboy closed this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants