Loosen up click constraint#845
Closed
eapolinario wants to merge 6 commits into
Closed
Conversation
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
=======================================
Coverage 87.19% 87.19%
=======================================
Files 248 248
Lines 22020 22020
Branches 2454 2454
=======================================
Hits 19200 19200
Misses 2395 2395
Partials 425 425 Continue to review full report at Codecov.
|
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
This reverts commit b752f2b. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
wild-endeavor
approved these changes
Feb 7, 2022
8 tasks
Collaborator
Author
|
Superseded by #838. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eduardo Apolinario eapolinario@users.noreply.github.com
TL;DR
clickstable version reached 8.0 recently. Time to bump that requirement to 9.0Type
Are all requirements met?
Complete description
The upper bound constraint in the version of
clickhas been set to8.0for a long time, butclickhas recently launched version8.0. We're starting to see some of our dependencies require at least 8.0 (for example,papermillrequiresblackwhich just recently set the lower bound to '>=8.0.0').Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/