Migrate ArrayJob to use TaskTemplate Config and deprecate ArrayJob proto#784
Migrate ArrayJob to use TaskTemplate Config and deprecate ArrayJob proto#784pingsutw wants to merge 8 commits into
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #784 +/- ##
=======================================
Coverage 86.63% 86.64%
=======================================
Files 243 242 -1
Lines 21452 21425 -27
Branches 2396 2397 +1
=======================================
- Hits 18586 18564 -22
+ Misses 2445 2440 -5
Partials 421 421 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
wild-endeavor
left a comment
There was a problem hiding this comment.
There was a spark test that failed - if it fails again, can you take a look?
Approving, but this is not a backwards compatible change wrt propeller right? Users will have to update propeller (plugins) in order to use this flytekit code. Can we test everything and then release propeller/plugins first, and make sure to specify what the minimum version of propeller needed is?
I created a PR for it #821
yeah, okay |
Signed-off-by: Kevin Su pingsutw@apache.org
TL;DR
Migrate ArrayJob to use TaskTemplate Config and deprecate ArrayJob proto
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#1791
Follow-up issue
NA