Mirror model changes from #751#756
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## model-refactor #756 +/- ##
=================================================
Coverage ? 85.88%
=================================================
Files ? 360
Lines ? 29927
Branches ? 2428
=================================================
Hits ? 25702
Misses ? 3586
Partials ? 639 Continue to review full report at Codecov.
|
eapolinario
reviewed
Nov 19, 2021
eapolinario
left a comment
eapolinario
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, I have just one minor question.
Comment on lines
+190
to
+195
| workflow_node_metadata=WorkflowNodeMetadata.from_flyte_idl(p.workflow_node_metadata) | ||
| if p.HasField("workflow_node_metadata") | ||
| else None, | ||
| task_node_metadata=TaskNodeMetadata.from_flyte_idl(p.task_node_metadata) | ||
| if p.HasField("task_node_metadata") | ||
| else None, |
Collaborator
There was a problem hiding this comment.
omg, this indentation.
| :param datetime.datetime started_at: | ||
| :param datetime.timedelta duration: | ||
| :param Text output_uri: | ||
| :param flytekit.models.core.execution.ExecutionError error: |
Collaborator
There was a problem hiding this comment.
why are you removing this?
Contributor
Author
There was a problem hiding this comment.
pushed - can you check again please?
eapolinario
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yee Hing Tong wild-endeavor@users.noreply.github.com
TL;DR
See https://github.com/flyteorg/flytekit/pull/751/files. This is just keeping the model files in line.