Move plugin models to be alongside plugins, remove legacy Sagemaker, Pytorch, notebook, and Tensorflow plugins#736
Merged
Merged
Conversation
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
- Coverage 85.74% 85.60% -0.15%
==========================================
Files 362 341 -21
Lines 29996 28917 -1079
Branches 2444 2382 -62
==========================================
- Hits 25721 24755 -966
+ Misses 3632 3528 -104
+ Partials 643 634 -9
Continue to review full report at Codecov.
|
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
changed the title
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
changed the title
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario
previously approved these changes
Nov 3, 2021
kumare3
reviewed
Nov 3, 2021
kumare3
reviewed
Nov 3, 2021
kumare3
reviewed
Nov 3, 2021
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
changed the title
eapolinario
approved these changes
Nov 4, 2021
reverson
pushed a commit
to reverson/flytekit
that referenced
this pull request
May 27, 2022
…Pytorch, notebook, and Tensorflow plugins (flyteorg#736) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Copy the model files for plugins into the microlib that uses them. We're copying instead of moving to support legacy use-cases, but the old definitions will be removed in 1.0. Removing sagemaker because it's not used.
Type
Are all requirements met?
Complete description
Delete.