Skip to content

[Bug] Error message isn't properly raised because abstract class is accessed during rendering of the error #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewphsmith merged 2 commits into from
Aug 23, 2019
Merged

[Bug] Error message isn't properly raised because abstract class is accessed during rendering of the error #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cd952e
The exception fails to raise properly because an abstract class is us…
matthewphsmith Aug 23, 2019
954f528
Add test for unparseable json
matthewphsmith Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions flytekit/common/types/containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,15 @@ def from_string(cls, string_value):
:param Text string_value:
:rtype: ListImpl<T>
"""

try:
items = _json.loads(string_value)
except ValueError:
raise _user_exceptions.FlyteTypeException(
_six.text_type, TypedListImpl, additional_msg='String not parseable to json {}'.format(string_value))
_six.text_type, cls, additional_msg='String not parseable to json {}'.format(string_value))

if type(items) != list:
raise _user_exceptions.FlyteTypeException(
_six.text_type, TypedListImpl, additional_msg='String is not a list {}'.format(string_value))
_six.text_type, cls, additional_msg='String is not a list {}'.format(string_value))

# Instead of recursively calling from_string(), we're changing to from_python_std() instead because json
# loading naturally interprets all layers, not just the outer layer.
Expand Down Expand Up @@ -130,7 +129,7 @@ def to_python_std(self):
"""
:rtype: list[T]
"""
return [self._sub_type.from_flyte_idl(l.to_flyte_idl()).to_python_std() for l in self.collection.literals]
return [type(self).sub_type.from_flyte_idl(l.to_flyte_idl()).to_python_std() for l in self.collection.literals]

def short_string(self):
"""
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ max-complexity=16
[tool:pytest]
norecursedirs = common workflows spark
log_cli = true
log_cli_level = 0
log_cli_level = 100

[pep8]
max-line-length = 120
Expand Down
6 changes: 6 additions & 0 deletions tests/flytekit/unit/common_tests/types/test_containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ def test_list():
with pytest.raises(_user_exceptions.FlyteTypeException):
list_type.from_string('[1, 2, 3, []]')

with pytest.raises(_user_exceptions.FlyteTypeException):
list_type.from_string('\'["not list json"]\'')

with pytest.raises(_user_exceptions.FlyteTypeException):
list_type.from_string('["unclosed","list"')


def test_string_list():
list_type = containers.List(primitives.String)
Expand Down