fix(spark): cap aiohttp<3.14 in test deps for aioresponses compat#3444
Closed
1fanwang wants to merge 1 commit into
Closed
fix(spark): cap aiohttp<3.14 in test deps for aioresponses compat#34441fanwang wants to merge 1 commit into
1fanwang wants to merge 1 commit into
Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Contributor
Author
|
Closing — pinning aiohttp only covers part of the spark build. It also fails on unrelated pyspark 4.x errors ( Path forward: the plugin builds need a dependency re-pin, not per-test fixes — |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The
flytekit-sparkbuild is red on master:aioresponsesmocks aClientResponsewithout thestream_writerargument thataiohttp3.14 made required, and the plugin's test deps don't capaiohttp(CI resolves 3.14.1).What changes were proposed in this pull request?
Cap
aiohttp<3.14inplugins/flytekit-spark/dev-requirements.in(test-only) untilaioresponsessupports 3.14.How was this patch tested?
Ran
plugins/flytekit-spark/tests/test_connector.pyin a fresh py3.12 venv that resolved the same deps as CI (aiohttp 3.14.1, aioresponses 0.7.8):test_databricks_agentfails withTypeError: ClientResponse.__init__() missing 1 required keyword-only argument: 'stream_writer'(aioresponses/core.py:172) — the exact error CI hits.dev-requirements.inresolves aiohttp 3.13.5; all 14 tests pass. TheInvalidSpecErrorseen later in the CI run was a cascade off that first failure (the test never reachedmock.patch.stopall()), so it clears too.Labels
fixed
Check all the applicable boxes