Add pip_extra_index_url as a supported parameter in default builder#2704
Merged
pingsutw merged 1 commit intoAug 23, 2024
Merged
Conversation
…lder Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
Future-Outlier,
cosmicBboy,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
- Coverage 78.91% 78.87% -0.05%
==========================================
Files 316 187 -129
Lines 24965 19232 -5733
Branches 4012 4017 +5
==========================================
- Hits 19702 15169 -4533
+ Misses 4548 3360 -1188
+ Partials 715 703 -12 ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
Aug 23, 2024
pingsutw
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
pip_extra_index_urlwas added in #2636, but the warning was not removed.What changes were proposed in this pull request?
This PR adds
pip_extra_index_urlas a supported option.How was this patch tested?
Ran image builder with no warning.