Update error message for TypeTransformerFailedError#2648
Merged
pingsutw merged 4 commits intoAug 5, 2024
Merged
Conversation
Signed-off-by: wayner0628 <a901639@gmail.com>
Signed-off-by: wayner0628 <a901639@gmail.com>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: wayner0628 <a901639@gmail.com>
Contributor
Author
|
Fixed the check fail where |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2648 +/- ##
===========================================
- Coverage 78.77% 54.83% -23.94%
===========================================
Files 187 236 +49
Lines 19149 21554 +2405
Branches 3993 3781 -212
===========================================
- Hits 15085 11820 -3265
- Misses 3374 9224 +5850
+ Partials 690 510 -180 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
approved these changes
Aug 5, 2024
|
Congrats on merging your first pull request! 🎉 |
Future-Outlier
pushed a commit
that referenced
this pull request
Aug 6, 2024
Signed-off-by: wayner0628 <a901639@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org>
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Aug 9, 2024
Signed-off-by: wayner0628 <a901639@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: mao3267 <chenvincent610@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to flyteorg/flyte#5353
Why are the changes needed?
TypeTransformerFailedErrordirectly and provide clearer feedback on unsupported type transformations instead of internalAttributeErrormessages likeAttributeError: 'NoneType' object has no attribute 'string_value'.What changes were proposed in this pull request?
AttributeErrorwhen a SimpleTransformer receives an incorrect literal format.How was this patch tested?
Executed unit tests using:
Screenshots
Running the above unit test on the master branch:
Running the above unit test on this new branch:
fix-check-simpletransformer-get-union-type-error-> No additional errors occur.
Check all the applicable boxes
Related PRs
N/A
Docs link
N/A