Raise an exception when filters' value isn't a list.#2576
Merged
Conversation
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2576 +/- ##
==========================================
- Coverage 78.77% 76.19% -2.58%
==========================================
Files 187 187
Lines 19149 19151 +2
Branches 3993 3994 +1
==========================================
- Hits 15085 14593 -492
- Misses 3374 3899 +525
+ Partials 690 659 -31 ☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Jul 12, 2024
Signed-off-by: Nelson Chen <asd3431090@gmail.com>
Collaborator
|
Can you add a unit test? |
Signed-off-by: Nelson Chen <asd3431090@gmail.com>
Contributor
|
@arbaobao This is not signed off yet. You can find instructions on how to sign off here: https://github.com/flyteorg/flytekit/pull/2576/checks?check_run_id=28277359939 |
Member
|
@arbaobao there is a linting error, could you run |
pingsutw
approved these changes
Aug 3, 2024
pingsutw
approved these changes
Aug 5, 2024
|
Congrats on merging your first pull request! 🎉 |
Future-Outlier
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Add an exeception when filters' value isn't a list * Make the exception more specific Signed-off-by: Nelson Chen <asd3431090@gmail.com> * add an unit test for value_in Signed-off-by: Nelson Chen <asd3431090@gmail.com> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Nelson Chen <asd3431090@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org>
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Aug 9, 2024
* Add an exeception when filters' value isn't a list * Make the exception more specific Signed-off-by: Nelson Chen <asd3431090@gmail.com> * add an unit test for value_in Signed-off-by: Nelson Chen <asd3431090@gmail.com> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Nelson Chen <asd3431090@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: mao3267 <chenvincent610@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link