Add myself to code owners of flytekit-kf-pytorch#2556
Merged
Conversation
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
fg91
requested review from
Future-Outlier,
cosmicBboy,
eapolinario,
kumare3,
pingsutw,
samhita-alla,
thomasjpfan and
wild-endeavor
as code owners
fg91
commented
Jul 3, 2024
Member
|
+1, let's wait for other maintainers' thought. |
pingsutw
approved these changes
Jul 3, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> Co-authored-by: Fabio Grätz <fabiogratz@googlemail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> Co-authored-by: Fabio Grätz <fabiogratz@googlemail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would it be ok for you if I add myself to the code owners for the
flytekit-kf-pytorchplugin (distributed pytorch training tasks)?I authored the
task_config=Elastic(...)task type of this plugin (#1603, flyteorg/flyteidl#394, flyteorg/flyteplugins#343, flyteorg/flytesnacks#987) and later contributed the following additional PRs to it:kubeflow.pytorchplugin instead of legacypytorchplugin #1678nproc_per_nodeintask_config=Elastic#1736I'd like to be notified on changes and would like to be able to approve PRs in this plugin. Thank you 🙏
Check all the applicable boxes