Dep: Pin grpcio in flytekit-identity-aware-proxy to version that allo…#2212
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2212 +/- ##
==========================================
- Coverage 85.86% 85.85% -0.01%
==========================================
Files 314 314
Lines 24042 24042
Branches 3643 3643
==========================================
- Hits 20643 20641 -2
- Misses 2759 2760 +1
- Partials 640 641 +1 ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
Feb 23, 2024
…ws non 'application/grpc' content type Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
58b3eca to
a4512aa
Compare
3 tasks
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
…ws non 'application/grpc' content type (#2212) Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> Co-authored-by: Fabio Grätz <fabiogratz@googlemail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a regression in
grpciowhich made a channel fail if the server responded with a content type other thanapplication/grpc.During flytekit's lazy authentication, GCP Identity Aware Proxy (IAP) responds with 401 and content type
text/htmlto the first unauthenticated request. For recentgrpcioversions, lazy authentication thus failed completely.I described this in detail in grpc/grpc#35323.
In #2156 I previously pinned
grpcioin the flytekit IAP plugin to versions without this regression.The grpc team now fixed the issue I reported. In this PR I therefore pin
grpcio>=1.62.0.I exclude the previously allowed versions because the error message
used to be logged during lazy authentication even though it did actually work.
With the newest version, no more error message is logged.