Skip to content

Fix typos and run spellcheck in CI#2074

Merged
eapolinario merged 5 commits into
masterfrom
fix-typos
Jan 18, 2024
Merged

Fix typos and run spellcheck in CI#2074
eapolinario merged 5 commits into
masterfrom
fix-typos

Conversation

@eapolinario

Copy link
Copy Markdown
Collaborator

Tracking issue

NA

Why are the changes needed?

Typos are annoying and make the project look unprofessional.

What changes were proposed in this pull request?

Fix current typos and run the spellchecker in CI.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@codecov

codecov Bot commented Dec 28, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7996c2e) 82.58% compared to head (3ce0611) 85.80%.

Files Patch % Lines
flytekit/core/type_engine.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
+ Coverage   82.58%   85.80%   +3.21%     
==========================================
  Files         233      313      +80     
  Lines       19541    23506    +3965     
  Branches     3512     3512              
==========================================
+ Hits        16138    20169    +4031     
+ Misses       2824     2729      -95     
- Partials      579      608      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
pingsutw
pingsutw previously approved these changes Dec 30, 2023
pingsutw
pingsutw previously approved these changes Jan 17, 2024
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario merged commit aaf69f8 into master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants