Fix module loading bug in instance tracker class#1902
Merged
Conversation
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
cosmicBboy
requested review from
eapolinario,
kumare3,
pingsutw and
wild-endeavor
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1902 +/- ##
===========================================
- Coverage 94.97% 55.08% -39.90%
===========================================
Files 135 301 +166
Lines 6115 22447 +16332
Branches 0 3371 +3371
===========================================
+ Hits 5808 12364 +6556
- Misses 307 9918 +9611
- Partials 0 165 +165
☔ View full report in Codecov by Sentry. |
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
cosmicBboy
changed the title
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
pingsutw
approved these changes
Oct 20, 2023
pingsutw
left a comment
pingsutw
left a comment
Member
There was a problem hiding this comment.
LGTM, Let's update the PR description before merging it
eapolinario
approved these changes
Oct 20, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
* modify instance tracker class Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * handle error in _get_module_from_main Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * add more comments Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR fixes an issue reported here where
pyflyteand other executables were trying to be loaded by thetracker.pymodule when finding trackable instances.Type
Are all requirements met?
[ ] Smoke tested[ ] Unit tests added(will be added subsequently)[ ] Code documentation added[ ] Any pending items have an associated IssueComplete description
The eager workflow PR introduced a bug that caused breakages in
@dynamicworkflows and agents. The underlying reason is that eager workflows need to be able to load task/dynamic/workflow functions asInstanceTrackingMetainstances so that it can execute them viaFlyteRemote. The issue is that, before1579,InstanceTrackingMetadid not support loading entities defined in the__main__module.This PR handles a module loading error that was being raised because the
trackermodule was trying to load thepyflyteand otherpyflyte-*executables.Tracking Issue
flyteorg/flyte#4245
Follow-up issue
#1892