Pickle as a default Transformer rather than a special case of function signatures#1661
Open
elibixby wants to merge 1 commit into
Open
Pickle as a default Transformer rather than a special case of function signatures#1661elibixby wants to merge 1 commit into
elibixby wants to merge 1 commit into
Conversation
elibixby
requested review from
cosmicBboy,
eapolinario,
kumare3,
pingsutw and
wild-endeavor
as code owners
8 tasks
Contributor
|
this seems to be abandoned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Right now only "top level" missing types (those defined directly in a function) are pickled if they don't have a registered
TypeTransformer. This PR alters that behavior to anywhereTypeTransformers are used.Type
Are all requirements met?
Complete description
The special casing for pickling as a serialization/deserialization method leads to some strange behavior where, e.g
Is valid, because that type is converted, but e.g.
Fooinside of a dataclass etc is not. Because the conversion to the placeholderFlytePickletype happens in a function which is only called once on top level type, and only traverses theoriginstack, rather than being used anywhereTypeTransformersare used. This PR fixes that problem, while also significantly simplifying the logic to support it.Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/