[release v1.2] Backport v1.6 by eapolinario · Pull Request #1644 · flyteorg/flytekit

eapolinario · 2023-05-16T23:40:47Z

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

Bug Fix
Feature
Plugin

Are all requirements met?

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Remove retry from flytekit's setup.py and regenerate requirements Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add to sagemaker Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove retry from sagemaker plugin requirements file Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Restore doc-requirements.txt Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Fix bad merge Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* fix: Make FlyteFile compatible with Annotated[..., HashMethod] See issue #3424 Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com> * tests: Add test case for FlyteFile with HashMethod annotation Issue: #3424 Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com> * fix: Use typing_extensions.Annotated for py3.8 compatibility Issue: #3424 Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com> * fix: Use `get_args` and `get_origin` from typing_extensions for py3.8 compatibility Issue: #3424 Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com> * fix(tests): Use fixture for local dummy file Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com> --------- Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com>

* move FlyteSchema deprecation warning to initialization method Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

…1515) * add pod_template and pod_template_name arguments for ContainerTask Signed-off-by: Felix Ruess <felix.ruess@roboception.de> * factor out _serialize_pod_spec into separate util function Signed-off-by: Felix Ruess <felix.ruess@roboception.de> * model file changes, couple other changes Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * minor cleanup Signed-off-by: Felix Ruess <felix.ruess@roboception.de> * add unit test for container_task pod_template Signed-off-by: Felix Ruess <felix.ruess@roboception.de> * bump min version of flyteidl to 1.3.12 for pod template data config support Signed-off-by: Felix Ruess <felix.ruess@roboception.de> * require flyteidl==1.3.12 in doc-requirements.txt Signed-off-by: Felix Ruess <felix.ruess@roboception.de> --------- Signed-off-by: Felix Ruess <felix.ruess@roboception.de> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Signed-off-by: franco-bocci <franco.bocci@wolt.com>

* TypeTransformer for TensorFlow model Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * clean up Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * clean up Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * fix lint Signed-off-by: Samhita Alla <aallasamhita@gmail.com> --------- Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Device auth flow Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Device AuthFlow is now available in flytekit Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * unit tests Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * test added Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Fixed test Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Fixed unit test Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Fixed lint errors Signed-off-by: Ketan Umare <ketan.umare@gmail.com> --------- Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* url encode secret first Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * nit Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * update comment Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

#1556) Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

Co-authored-by: ggydush-fn <greg.gydush@freenome.com>

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Automatically remove unused import Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

* Disallow partial lists in map tasks Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Lint Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com>

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Convert List[Any] to a single pickle file * remove redundant code * keep batchSize only if type contain flytePickle * fix error * add batch support to translate_inputs_to_literals * add ci test Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * improve comment Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * add more ci test Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * improve Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * handle HashMethod case Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * improve format Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * improve Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * improve Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * improve Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * add test_is_batchable Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * Add BatchSize Signed-off-by: Kevin Su <pingsutw@apache.org> * test_batch_size Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: root <root@ip-172-31-10-58.ec2.internal> Co-authored-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* Unify sqlalchemy Dockerfiles Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Simplifyte sqlalchemy Dockerfile Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Set pythonpath to /root Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com>

* wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * pyflyte build Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * Support serialize and package Signed-off-by: Kevin Su <pingsutw@apache.org> * more tests Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * move to plugin Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * fixed tested Signed-off-by: Kevin Su <pingsutw@apache.org> * fixed tested Signed-off-by: Kevin Su <pingsutw@apache.org> * more tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Add support passing yaml in pyflyte run Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

…ror messages (#1582) * improve input type conversion error Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix lint Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * add tests Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * add tests Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * add rich Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix lint Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * remove prototyping script, update loggers Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update __init__.py Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update logger Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update logger Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix GE and pandera tests Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix lint Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* Add support nested FlyteFile in pyflyte run Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

* Set cache_regions=True in the case of s3fs * Linting Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Fix tests Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * More linting Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com>

* set default ComSpec when running on Windows Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

* add activate-launchplan command to pyflyte Signed-off-by: Artem Petrov <58334441+wckdman@users.noreply.github.com> * fix linting Signed-off-by: Artem Petrov <58334441+wckdman@users.noreply.github.com> * rework launchplan command Signed-off-by: Artem Petrov <58334441+wckdman@users.noreply.github.com> * fix linting Signed-off-by: Artem Petrov <58334441+wckdman@users.noreply.github.com> --------- Signed-off-by: Artem Petrov <58334441+wckdman@users.noreply.github.com>

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* checkpoint Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Experimental implementation works well. Instead of messing with the class, we utilize the interpolation and context to dynamically generate a wrapper around the desired script. In the wrapper, we cd to the ctx.working_directory, export the env variables (handled by an additional method to convert dict to str), and then pass the arguments to the script Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * fix spacing Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * remove breakpoint Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Output ctx.working_directory as single output Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * more doc strings Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * more comments Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Added comments Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Add tests and test files from other branch Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * minor fix, have function return the instance rather than create. It seems to get registered when flyte packages your project Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * fix tests Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * remove set flags not supported by sh Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * fix spellcheck lint errors Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * don't have a windows equivalent test script so bypassing those tests for now Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Add typing to make_export_string_from_env_dict params Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * fixup doc string Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Refactored the new behavior out into a new class. Did not change implementation details at all Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Address linter issues and up test cov Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Skip test on windows, no equivalent script Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Run black and isort, address SC2236 Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Refactored class name to remove _, make utility function require name so multiple uses in a workflow don't break Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * fix utility function Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * fix utility function call in tests Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * Fix isort on test_shell.py Signed-off-by: Mike Zhong <mzhong@embarkvet.com> * adding logging settings to papermill plugin Signed-off-by: Calvin Leather <cleather@embarkvet.com> * set level to info logging * improved comments/docs --------- Signed-off-by: Mike Zhong <mzhong@embarkvet.com> Signed-off-by: Calvin Leather <cleather@embarkvet.com> Co-authored-by: Mike Zhong <mzhong@embarkvet.com> Co-authored-by: Mike Zhong <mike.zhong89@gmail.com>

* Pyflyte prettified Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * added dependency Signed-off-by: Ketan Umare <ketan.umare@gmail.com> --------- Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* pyflyte run now supports json files Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * added yaml support Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * fixed parsing Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * fixed windows test Signed-off-by: Ketan Umare <ketan.umare@gmail.com> --------- Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* Add is_inside func to ImageSpec Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * Add is_inside func to ImageSpec Signed-off-by: Kevin Su <pingsutw@apache.org> * Add tests Signed-off-by: Kevin Su <pingsutw@apache.org> * rename Signed-off-by: Kevin Su <pingsutw@apache.org> * rename Signed-off-by: Kevin Su <pingsutw@apache.org> * check execution mode Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

) * add time measurement framework Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * add time measurement framework Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * nit Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * nit Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * nit Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * nit Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> * nit Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com> --------- Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>

…1614) * Fixed tests Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * add lru cache Signed-off-by: Kevin Su <pingsutw@apache.org> * update Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

@task

Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com> This PR brings [torch elastic training (`torchrun`)](https://pytorch.org/docs/stable/elastic/run.html) to the pytorch plugin: ```python from flytekitplugins.kfpytorch import Elastic @task( task_config=Elastic( replicas=4, nproc_per_node=4, ... ), ... ) def train(...): ... ``` flyteorg/flyte#3614

* update sphinx youtube plugin Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Add default spark image Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

* lazy load module Signed-off-by: Kevin Su <pingsutw@apache.org> * lazy load module Signed-off-by: Kevin Su <pingsutw@apache.org> * import Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * keep structured dataset in flytekit init Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * fixed tess Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * fixed tests Signed-off-by: Kevin Su <pingsutw@apache.org> * fixed tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * move import pandas to __init__ Signed-off-by: Kevin Su <pingsutw@apache.org> * use lazy import loader instead Signed-off-by: Kevin Su <pingsutw@apache.org> * Fixed tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fixed tests Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * regular import Signed-off-by: Kevin Su <pingsutw@apache.org> * fixed tests Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

* override node_name with a name containing underscore Signed-off-by: Kevin Su <pingsutw@apache.org> * add comment Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

External Plugin Service

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Add support for copying all the files in source root Signed-off-by: Kevin Su <pingsutw@apache.org> * Add tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: esad <esad@peridotml.io>

Signed-off-by: Kevin Su <pingsutw@apache.org>

…ts inputs in papermill plugin (#1612)

Signed-off-by: Kevin Su <pingsutw@apache.org>

Without the overload, the decorated function does not have the proper type of PythonFunctionTask, leading to spurious type errors when attempting to register the task on a FlyteRemote object Signed-off-by: Matthew Hoffman <matthew@protopia.ai>

* add annotation option for serialization * add support for guessing type * formatting * test both directions * remove guessing for annotated types * clarify usage in test * Update tests/flytekit/unit/core/test_type_engine.py --------- Co-authored-by: Eli Bixby <eli@cradle.bio> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

Previously, the workflow decorator is hinted as always returning a WorkflowBase, which is not true when _workflow_function is None; similar to #1631, we propose using typing.overload to differentiate the return type of workflow based on the value of _workflow_function Signed-off-by: Matthew Hoffman <matthew@protopia.ai>

* wip Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix mypy errors Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix mypy errors Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * fix test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * Update type Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * update dev-requirements.txt Signed-off-by: Kevin Su <pingsutw@apache.org> * Address comment Signed-off-by: Kevin Su <pingsutw@apache.org> * upgrade torch Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@gmail.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>

eapolinario · 2023-05-17T00:57:34Z

superseded by #1645.

wild-endeavor and others added 30 commits May 16, 2023 14:00

Data subsystem (#1526)

4555578

Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Update the pypi wait (#1554)

2731766

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Stream Directories and Files using Flyte (#1512)

0c47d46

Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Pass locally defined scopes to RemoteClientConfigStore (#1553)

b22e5e3

Signed-off-by: franco-bocci <franco.bocci@wolt.com>

Remove fsspec flytekit plugin from main Dockerfile (#1561)

bd6a7e5

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

General Partial support in flytekit and multi-list support in flytekit (

9a31a01

#1556) Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

fix: Silence keyring warnings by changing to debug (#1568)

d8c10c6

Co-authored-by: ggydush-fn <greg.gydush@freenome.com>

Support GCP secrets (#1571)

06ea83b

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Automatically remove unused import (#1574)

57e21c2

* Automatically remove unused import Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

Remove duplicate reporting logic (#1578)

0c0c2ac

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Improve authoring structure documentation (#1572)

8941718

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

nit (#1596)

34ea031

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

kumare3 and others added 24 commits May 16, 2023 15:36

Pyflyte prettified (#1602)

66a3ee6

* Pyflyte prettified Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * added dependency Signed-off-by: Ketan Umare <ketan.umare@gmail.com> --------- Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

update sphinx youtube plugin (#1619)

33a2f32

* update sphinx youtube plugin Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

Read polar dataframe without copying to local (#1618)

b2fb4bf

Signed-off-by: Kevin Su <pingsutw@apache.org>

Override node name with a name containing underscore (#1608)

7c64c8d

* override node_name with a name containing underscore Signed-off-by: Kevin Su <pingsutw@apache.org> * add comment Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

External Plugin Service (grpc) (#1524)

a04a128

External Plugin Service

Include traceback in errors from admin (#1621)

d9174fd

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

fix PipelineModel transformer issue 3648 (#1623)

4c23c91

Signed-off-by: esad <esad@peridotml.io>

update GH workflow for external plugin service (#1624)

a7391c9

Signed-off-by: Kevin Su <pingsutw@apache.org>

[Issue-3617] Enables FlyteFiles, FlyteDirectors, and StructuredDatase…

7409889

…ts inputs in papermill plugin (#1612)

Add support for using a list as an input for a subworkflow (#1605)

396080c

Signed-off-by: Kevin Su <pingsutw@apache.org>

Delete removed data persistence classes from docs (#1633)

fc065db

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

type-protobuf<4

725cdb7

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>

eapolinario requested review from cosmicBboy, kumare3, pingsutw and wild-endeavor as code owners May 16, 2023 23:40

eapolinario closed this May 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release v1.2] Backport v1.6#1644

[release v1.2] Backport v1.6#1644
eapolinario wants to merge 61 commits into
release-v1.2from
release-v1.2-backport-1.6

eapolinario commented May 16, 2023

Uh oh!

eapolinario commented May 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Uh oh!

Conversation

eapolinario commented May 16, 2023

TL;DR

Type

Are all requirements met?

Complete description

Tracking Issue

Follow-up issue

Uh oh!

eapolinario commented May 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants