Skip building the image if failed to check if image exists#1609
Closed
pingsutw wants to merge 18 commits into
Closed
Skip building the image if failed to check if image exists#1609pingsutw wants to merge 18 commits into
pingsutw wants to merge 18 commits into
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
cosmicBboy,
eapolinario,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
==========================================
- Coverage 70.16% 70.10% -0.06%
==========================================
Files 328 328
Lines 30142 30156 +14
Branches 5448 5452 +4
==========================================
- Hits 21149 21141 -8
- Misses 8465 8485 +20
- Partials 528 530 +2
|
pingsutw
changed the title
Signed-off-by: Kevin Su <pingsutw@apache.org>
| except Exception as e: | ||
| tag = calculate_hash_from_image_spec(self) | ||
| # if docker engine is not running locally | ||
| response = requests.get(f"https://hub.docker.com/v2/repositories/{self.registry}/{self.name}/tags/{tag}") |
Contributor
There was a problem hiding this comment.
let's kill this section for now. the url should be from the registry, not hard-coded here, but we have to think about tokens and such...
| flytekit_virtualenv_root=self.flytekit_virtualenv_root, | ||
| python_interpreter=self.python_interpreter, | ||
| fast_serialization_settings=self.fast_serialization_settings, | ||
| source_root=self.source_root, |
Contributor
There was a problem hiding this comment.
is this change still needed? or just for cleanliness?
Member
Author
There was a problem hiding this comment.
yes, we need it for dynamic task
wild-endeavor
approved these changes
May 1, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Skip building the image if failed to check if image exists, and we assume image already exists.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA