Skip to content

Use fsspec placeholder for structured dataset#1543

Merged
wild-endeavor merged 6 commits into
data-subsystemfrom
data-subsystem-sd-generalize
Mar 9, 2023
Merged

Use fsspec placeholder for structured dataset#1543
wild-endeavor merged 6 commits into
data-subsystemfrom
data-subsystem-sd-generalize

Conversation

@wild-endeavor

@wild-endeavor wild-endeavor commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

This is a PR to #1526

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor wild-endeavor changed the title use default Use fsspec placeholder for structured dataset Mar 9, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@codecov

codecov Bot commented Mar 9, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1543 (82812d7) into data-subsystem (d17f3bc) will increase coverage by 0.00%.
The diff coverage is 79.06%.

@@               Coverage Diff               @@
##           data-subsystem    #1543   +/-   ##
===============================================
  Coverage           69.64%   69.65%           
===============================================
  Files                 310      310           
  Lines               28675    28685   +10     
  Branches             2715     2719    +4     
===============================================
+ Hits                19972    19981    +9     
+ Misses               8197     8195    -2     
- Partials              506      509    +3     
Impacted Files Coverage Δ
tests/flytekit/unit/core/test_type_hints.py 95.61% <ø> (-0.02%) ⬇️
flytekit/types/structured/structured_dataset.py 60.21% <76.92%> (+0.92%) ⬆️
...ests/flytekit/unit/core/test_structured_dataset.py 99.03% <100.00%> (+<0.01%) ⬆️
...ekit/unit/core/test_structured_dataset_handlers.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor wild-endeavor mentioned this pull request Mar 9, 2023
8 tasks
@wild-endeavor wild-endeavor merged commit b417d60 into data-subsystem Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant