Backport to 1.2 - Flytekit Auth system overhaul and pretty printing upgrade (#1458)#1525
Merged
Conversation
* [wip] New authentication system - Reuse local keyring better - use grpc based auth system Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Better error handling and printing, better exception handling and retrying Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Delete legacy files Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * add missing None Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.home> * keyring removed Signed-off-by: Ketan Umare <ketanumare@Ketans-MacBook-Pro.local> * added insecure_skip_verify Signed-off-by: Ketan Umare <ketanumare@Ketans-MacBook-Pro.local> * test fixed Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI> * Test fixed Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI> * Auth update Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI> * updated test Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * flush buffer instead of closing, was getting a weird stack trace. make the image smaller Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * updated ca-cert logic Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Fixed unit tests Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * test fix Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * nest raise if exc Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * added keyring.alt for tests Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Lint Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.home> Signed-off-by: Ketan Umare <ketanumare@Ketans-MacBook-Pro.local> Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Ketan Umare <ketanumare@Ketans-MBP.home> Co-authored-by: Ketan Umare <ketanumare@Ketans-MacBook-Pro.local> Co-authored-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
requested review from
cosmicBboy,
kumare3,
pingsutw and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## release-v1.2 #1525 +/- ##
===============================================
Coverage ? 69.08%
===============================================
Files ? 314
Lines ? 28760
Branches ? 2324
===============================================
Hits ? 19870
Misses ? 8361
Partials ? 529 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Remove mentions to spark Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove mentions to requirements.txt and dev-requirements.txt Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove plugins requirements. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove all_requirements target from plugins makefile Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use dev-requirements.in in lint gh action job Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Revert "Remove all_requirements target from plugins makefile" This reverts commit 50cbb4d. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Revert "Remove plugins requirements." This reverts commit eae945c. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
* Remove mentions to spark Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove mentions to requirements.txt and dev-requirements.txt Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove plugins requirements. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove all_requirements target from plugins makefile Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use dev-requirements.in in lint gh action job Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Revert "Remove all_requirements target from plugins makefile" This reverts commit 50cbb4d. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Revert "Remove plugins requirements." This reverts commit eae945c. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
wild-endeavor
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Backport "Flytekit Auth system overhaul and pretty printing upgrade (#1458)" and a few bookkeeping to release-v1.2
Type
Are all requirements met?
Complete description
This change backports the following commits:
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/